Update stderr manipulation code in test helper #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running in an IDE causes this code to fail, so instead its safely neutered with this approach.
semanticart
approved these changes
Feb 18, 2025
Contributor
semanticart
left a comment
semanticart
left a comment
There was a problem hiding this comment.
The skip behavior felt a little weird at first, but we have CI to keep us honest 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update stderr manipulation code in test helper
running in an IDE causes this code to fail, so instead its safely neutered with this approach.
errors like
I think we could use IO.pipes or something so that everyone can read the stderr together but this is simple
Testing & Validation
Run the tests